Repository navigation
[Server] Keep implicit stdio sessions alive while connected - #743
Open
Christiansada wants to merge 1 commit into
Open
Christiansada wants to merge 1 commit into
Christiansada wants to merge 1 commit into
Conversation
Christiansada
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 13, 2026 12:44
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the default stdio session-lifetime change.
No open issues 🎉
What changed in this PR
Addresses #672 by keeping default stdio sessions alive until connection closure, while preserving explicitly configured session lifecycles.
Changes:
- Removes the practical idle timeout for implicit in-memory sessions without changing explicit session defaults or custom stores.
- Adds regression coverage for two hours of idle time, a correlated ping response, and cleanup at connection closure.
- Documents the default and explicitly configured stdio session lifecycles.
| File | Description |
|---|---|
| tests/Unit/Server/BuilderTest.php | Tests idle survival, connection cleanup, explicit expiry, and custom-store retention. |
| src/Server/Builder.php | Uses the maximum integer TTL for the implicit in-memory session store. |
| docs/run/sessions.md | Clarifies stdio session lifetime and setSession() behavior. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the default-configuration failure in #672: implicit stdio sessions survive idle time until connection closure, while
setSession()retains the HTTP default and custom stores/managers retain their configured lifecycle. The regression covers a simulated two-hour idle interval, a correlated ping response and EOF cleanup; explicitly configured short TTLs are intentionally unchanged.